-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build target which creates debug image #110
Open
replay
wants to merge
13
commits into
main
Choose a base branch
from
v0.8.3_debug_image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
43ca1df
build debug image
replay befa19f
only arm
replay 1415066
add target to publish debug image
replay a53a136
update title
replay b6a6cb3
correct tag prefix
replay 04a2d3a
same repo different tag
replay 0641cd1
fix dlv path
replay 714108c
fix delve parameters
replay 21d43ba
fix build flags
replay c1d94f5
go install dlv like normal
replay 1d4005d
update alpine
replay 97d27f4
comment
replay bed708e
separate build targets per arch for local builds
replay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
FROM golang:1.21-alpine3.19 AS build | ||
|
||
ARG TARGETOS | ||
ARG TARGETARCH | ||
ARG BUILDTARGET=rollout-operator-debug | ||
|
||
RUN apk add --no-cache build-base git | ||
|
||
COPY . /src/rollout-operator | ||
WORKDIR /src/rollout-operator | ||
RUN go install github.com/go-delve/delve/cmd/[email protected] | ||
RUN /go/bin/dlv -h | ||
RUN GOOS=${TARGETOS} GOARCH=${TARGETARCH} make ${BUILDTARGET} | ||
|
||
FROM alpine:3.19 | ||
RUN apk add --no-cache ca-certificates | ||
|
||
COPY --from=build /go/bin/dlv /bin/dlv | ||
COPY --from=build /src/rollout-operator/rollout-operator /bin/rollout-operator | ||
ENTRYPOINT [ "/bin/dlv", "--headless=true", "--listen=:49988", "--api-version=2", "--accept-multiclient", "exec", "/bin/rollout-operator" , "--continue", "--"] | ||
|
||
# Create rollout-operator user to run as non-root. | ||
RUN addgroup -g 10000 -S rollout-operator && \ | ||
adduser -u 10000 -S rollout-operator -G rollout-operator | ||
USER rollout-operator:rollout-operator | ||
|
||
ARG revision | ||
LABEL org.opencontainers.image.title="rollout-operator-debug" \ | ||
org.opencontainers.image.source="https://github.com/grafana/rollout-operator" \ | ||
org.opencontainers.image.revision="${revision}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't update to alpine 3.19 yet, see #97.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above has been resolved now, but the main Dockerfile now compiles in bookworm. I don't think that difference matters here besides consistency.