[WIP] PoC for managing Grafana App Platform resources #2006
Conversation
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Signed-off-by: Igor Suleymanov <[email protected]>
Signed-off-by: Igor Suleymanov <[email protected]>
Signed-off-by: Igor Suleymanov <[email protected]>
Signed-off-by: Igor Suleymanov <[email protected]>
Signed-off-by: Igor Suleymanov <[email protected]>
Signed-off-by: Igor Suleymanov <[email protected]>
Signed-off-by: Igor Suleymanov <[email protected]>
Signed-off-by: Igor Suleymanov <[email protected]>
Signed-off-by: Igor Suleymanov <[email protected]>
radiohead
force-pushed
the
feat/app-platform-poc
branch
from
b6fef2c to
1fc73cd
Compare
There was a problem hiding this comment.
I've added this as a temporary solution, to isolate all required changes in one place. However, this ended up requiring moving the common.Client from internal to pkg, because it wasn't otherwise possible to re-use it in this submodule.
If we are going to stick to the submodule approach, we'll need to think about a cleaner way to address the changes to the common.Client.
There was a problem hiding this comment.
This is 90% there, just needs validation for item types (since those are an enum).
There was a problem hiding this comment.
This is the main piece of work here, would be nice to get feedback on it.
There was a problem hiding this comment.
These will be moved and imported from grafana/grafana (same way as playlists are imported right now).
There was a problem hiding this comment.
@IfSentient I'm thinking about adding these 2 clients (resource & namespaced) to app SDK, thoughts?
There was a problem hiding this comment.
I think that makes sense, I think we might want to rename the NamespacedClient, as it's actually a Namespaced ResourceClient, and grafana/grafana-app-sdk#194 will likely need to introduce a namespaced general client/registry.
There was a problem hiding this comment.
Great! I'm happy to rename / change things slightly – what's here is definitely not final.
|
@Duologic @K-Phoen @IfSentient this is still WIP but if you have some time I'd appreciate general feedback for this! Especially about the submodule approach – I'd like to know if we should stick with it or not. |
|
On first scan:
|
|
Thank you for taking a look!
If you are OK with not using a submodule it will make client refactoring unnecessary – the only reason I've done it was to make it importable from a submodule. Let me know if dropping the submodule is fine and I'll update accordingly.
Yes, I'm working on moving the dashboard schemas to |
|
I don't really understand which problem the submodule is solving tbh. What are the trade offs of dropping the submodule? |
The main reason I've introduced one was to isolate the changes and the dependencies. I am 100% happy to drop it. |
What
This PR is a PoC for managing Grafana App Platform resources via Terraform. It implements a generic GAP resource, generic client and implements two new resources – dashboards and playlists.
The dashboard resource also supports validation (using
grafana/foundation-sdkand linting usinggrafana/dashboard-linter.This is still WIP and parts of this code will be move to other repositories (e.g. generated dashboards code will be moved to
grafana/grafana, resource clients tografana/grafana-app-sdkand so on).Why
To add support for GAP resources and improve the existing Grafana dashboards resource specifically.
The code for specific resources should ideally be auto-generated by something (likely something similar or same as in https://github.com/grafana/terraform-provider-schemas/tree/main/gen).