-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to homepage #326
base: main
Are you sure you want to change the base?
Conversation
@joey-grafana Small feedback, I'd enlarge the spacing between the data source input and the text "filter" sightly to distinguish both filters. Right now, it's hard to tell which belongs together. |
@joey-grafana @nadinevehling Would it be easy that instead of a single filter option we use the same filter that we have in the app? Rationale: Keep the same experience that we have in the app, the app filter is more flexible, and we would avoid having to create a new set of interactions. Feedback on the current filter:
Minor comment: When I selected an attribute in the filter, the "Errors" pane reconfigured to show the errors breakdown by the selected attribute even if I haven't entered an attribute value. However, the "Slow traces" pane didn't change until I selected also a value. This was slightly confusing not knowing if it was a bug or not. |
Fantastic work @joey-grafana - leaving a few individual comments below. Error for certain filtersThere is an error for certain filters, such as The query is the following:
answered with 400 Bad Request - compiling query: parse error at line 1, col 53: syntax error: unexpected IDENTIFIER This could be because of missing quotes around
I think we have a similar issue in the app filter, but there the quotes are added for non-string values. Happy to park this and try to tackle separately. Not possible to type regexWhen choosing a regex match, I can only select from the drop down, but not enter a regex. If too complex to enable typical values, perhaps we could leave regex out for now. |
Internal user interviews showed us that users would like the ability to select which service/cluster/etc that are most interested in or simply to see errors/slow traces for an attribute other than
resource.service.name
. Having spoken with @nadinevehling & @alexbikfalvi, we decided to allow users to add an optional filter for this iteration and based on feedback we will decide if we want to allow them to add more than one filter/create views (something like what Explore Logs does), but for this iteration it was requested to walk before we run :DFixes grafana/grafana#99862