Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Peak RPS calculation, shared tooltip and fix VU display in the Performance Overview #165

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

Sea-you
Copy link
Contributor

@Sea-you Sea-you commented Apr 29, 2024

  • Add a fix to the Peak RPS calculation by adding the Reduce (to max) transformation.
  • Set shared tooltip in the Performance Overview panel
  • Calculate the number of VUs by summing instead of average as it might mislead if you're testing with multiple instances. In our case 4 nodes, each 250 VUs. Previously this would have been displayed as 250 instead of 1000.
image

@Sea-you Sea-you requested a review from a team as a code owner April 29, 2024 09:24
@Sea-you Sea-you requested review from mstoykov and olegbespalov and removed request for a team April 29, 2024 09:24
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024

CLA assistant check
All committers have signed the CLA.

@olegbespalov olegbespalov requested a review from ppcano April 29, 2024 09:34
Copy link
Contributor

@ppcano ppcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sea-you, thanks for fixing this and the improvements.

I think it is ready after removing the id property.

grafana/dashboards/k6-prometheus.json Outdated Show resolved Hide resolved
grafana/dashboards/k6-prometheus.json Outdated Show resolved Hide resolved
grafana/dashboards/k6-prometheus.json Outdated Show resolved Hide resolved
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I'll address linter issues separately 👍

@ppcano
Copy link
Contributor

ppcano commented Apr 30, 2024

@Sea-you, thanks for fixing the issue, improving the dashboard, and sharing it with the community!

@ppcano ppcano merged commit 1a03ade into grafana:main Apr 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants