-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Peak RPS calculation, shared tooltip and fix VU display in the Performance Overview #165
Conversation
Sea-you
commented
Apr 29, 2024
- Add a fix to the Peak RPS calculation by adding the Reduce (to max) transformation.
- Set shared tooltip in the Performance Overview panel
- Calculate the number of VUs by summing instead of average as it might mislead if you're testing with multiple instances. In our case 4 nodes, each 250 VUs. Previously this would have been displayed as 250 instead of 1000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sea-you, thanks for fixing this and the improvements.
I think it is ready after removing the id
property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I'll address linter issues separately 👍
@Sea-you, thanks for fixing the issue, improving the dashboard, and sharing it with the community! |