feat(free): add readKeys method to free session storage adapter #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the readKeys Method to the Free Session Storage Adapter -Problem Right now, we have a read method that lets you read a session, but it requires a key. The question is... how do you get that key? Well, I have no idea. -Solution The new readKeys method helps you fetch all available keys, which you can then use with read to get specific session data. -Changes Due to readKeys - key in call is now optional, allowing global calls. - The URL structure now depends on key: - If key is provided, you want to read a specific session (like read does now). - If key is missing, you want to retrieve all session keys (which readKeys now handles). -Notes The endpoint /sessions used for readKeys is provided by the free storage adapter server here: https://github.com/grammyjs/free-session-backend/blob/778a383057e7b8a244fdb2beee20542d8ce0867b/src/main.ts#L89 PS: Hope this helps someone in the future, just like it helped me today! Hihihi
KnorpelSenf
requested changes
Feb 21, 2025
…sion keys Co-authored-by: KnorpelSenf <[email protected]>
…lready implemented Co-authored-by: KnorpelSenf <[email protected]>
KnorpelSenf
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Great stuff! Thanks! Let's wait for another review by @Satont who maintains the storage adapters before merging this
|
ok well ;) |
|
I think that here also a readSessions method could be implemented, to directly provide all available sessions. I currently need to retrieve all my sessions and migrate to mongodb. by looping the read method with the keys it is possible but it would be more efficient if a readSessions was implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
readAllKeysMethod to the Free Session Storage AdapterProblem
Right now, we have a
readmethod that lets you read a session, but it requires akey. The question is... how do you get thatkey? Well, I don't know ;)Solution
The new
readAllKeysmethod helps you fetch all available keys, which you can then use withreadto get specific session data.Changes Due to
readAllKeyskeyincallis now optional, allowing global requests.key:keyis provided, you want to read a specific session (likereaddoes now).keyis missing, you want to retrieve all session keys (whichreadAllKeysnow handles).Notes
The endpoint
/sessionsused forreadAllKeysis provided by the storage adapter server here:https://github.com/grammyjs/free-session-backend/blob/778a383057e7b8a244fdb2beee20542d8ce0867b/src/main.ts#L89
PS: Hope this helps someone in the future, just like it helped me today! Hihihi