Improve docs #8
Merged
Improve docs #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjust
approved these changes
May 24, 2024
| @@ -28,6 +28,21 @@ def jaccard_similarity( | |||
| return float(intersection / union) | |||
|
|
|||
|
|
|||
| def _composition_count_worker( | |||
There was a problem hiding this comment.
Good catch! Surprising (at least to me) behaviour of multiprocessing here
There was a problem hiding this comment.
Yes, I was also quite puzzled - it was throwing errors in Python 3.10 but I think worked fine in 3.8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put together a quick jupyter notebook to act as introductory walk-through of the library functionalities, and integrated it into the sphinx documentation. Minor changes to README and auxiliary files.