Fix pVACvector bug that would result in not all junctional epitopes getting tested on clipping #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting tested on clipping
susannasiebert
force-pushed
the
pvacvector_bug
branch
from
33cf5d7 to
0285cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clipping, we would remove amino acids at the beginning and/or end of a peptide sequence but we wouldn't include additional amino acids to make up for the clipped amino acids. This resulted in not all potential junctional epitopes getting tested.
Example:
peptide1 -> peptide 2 junction for a 9mer junctional epitopes:
buggy junction when clipping the end of peptide1 by 1 amino acid (without this fix):
correct junction (with this fix):