Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3836. SetupFakeDriver sometimes causes failure in the unit test. #3879

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Dec 3, 2024

Fixes

Proposed Changes/Todos

  • Application.Screen was causing this issue because _screen wasn't being set to null after running a test using the SetupFakeDriver.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner December 3, 2024 22:40
@BDisp
Copy link
Collaborator Author

BDisp commented Dec 3, 2024

This error doesn't happens all the time. It's a racing condition when a unit test that use the SetupFakeDriver after it's finished and another unit test that doesn't use it start and will call the superView.SetRelativeLayout (new (10, 10)); when the Application.Screen was already be set to that size before in the first unit test.

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Thanks.

@tig tig merged commit 5367e7b into gui-cs:v2_develop Dec 5, 2024
4 checks passed
@BDisp BDisp deleted the v2_3836_setupfakefriver-after-fix branch December 5, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetupFakeDriver sometimes causes failure in the unit test.
2 participants