Add Long-press (left button down) action for long press gesture

Enabling this action will disable Long-press-swipe gesture because we can't wait for ACTION_UP event in this case.
gujjwal00 · Jan 29, 2025 · 867a963 · 867a963
1 parent 20b3a8e
commit 867a963
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 1 deletion.
diff --git a/app/src/main/java/com/gaurav/avnc/ui/prefs/PrefsActivity.kt b/app/src/main/java/com/gaurav/avnc/ui/prefs/PrefsActivity.kt
@@ -121,6 +121,8 @@ class PrefsActivity : AppCompatActivity(), PreferenceFragmentCompat.OnPreference
                 disabledStateSummary = getString(R.string.pref_gesture_action_move_pointer)
             }
             findPreference<ListPreferenceEx>("gesture_long_press_swipe")!!.apply {
+                enableIf { it["gesture_long_press"] != "left-press" }
+                disabledStateSummary = getString(R.string.pref_gesture_action_none)
                 helpMessage = getText(R.string.msg_drag_gesture_help)
             }
 

diff --git a/app/src/main/java/com/gaurav/avnc/ui/vnc/Dispatcher.kt b/app/src/main/java/com/gaurav/avnc/ui/vnc/Dispatcher.kt
@@ -83,6 +83,7 @@ class Dispatcher(private val activity: VncActivity) {
 
         private fun selectPointAction(actionName: String): (PointF) -> Unit {
             return when (actionName) {
+                "left-press" -> { p -> defaultMode.doButtonDown(PointerButton.Left, p) }
                 "left-click" -> { p -> defaultMode.doClick(PointerButton.Left, p) }
                 "double-click" -> { p -> defaultMode.doDoubleClick(PointerButton.Left, p) }
                 "middle-click" -> { p -> defaultMode.doClick(PointerButton.Middle, p) }

diff --git a/app/src/main/java/com/gaurav/avnc/util/AppPreferences.kt b/app/src/main/java/com/gaurav/avnc/util/AppPreferences.kt
@@ -53,7 +53,7 @@ class AppPreferences(context: Context) {
         val swipe2; get() = prefs.getString("gesture_swipe2", "pan")!!
         val doubleTapSwipe; get() = prefs.getString("gesture_double_tap_swipe", "remote-drag")!!
         val longPressSwipe; get() = prefs.getString("gesture_long_press_swipe", "none")!!
-        val longPressSwipeEnabled; get() = (longPressSwipe != "none")
+        val longPressSwipeEnabled; get() = (longPressSwipe != "none" && longPress != "left-press")
         val longPressDetectionEnabled; get() = (longPress != "none" || longPressSwipeEnabled)
         val swipeSensitivity; get() = prefs.getInt("gesture_swipe_sensitivity", 10) / 10f
         val invertVerticalScrolling; get() = prefs.getBoolean("invert_vertical_scrolling", false)

diff --git a/app/src/main/res/values/arrays.xml b/app/src/main/res/values/arrays.xml
@@ -77,12 +77,14 @@
         <item>@string/pref_gesture_action_double_click</item>
         <item>@string/pref_gesture_action_middle_click</item>
         <item>@string/pref_gesture_action_right_click</item>
+        <item>@string/pref_gesture_action_left_press</item>
     </string-array>
     <string-array name="long_press_action_values">
         <item>none</item>
         <item>double-click</item>
         <item>middle-click</item>
         <item>right-click</item>
+        <item>left-press</item>
     </string-array>
 
     <string-array name="swipe1_action_entries">

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -152,6 +152,7 @@
 
     <string name="pref_gesture_action_none" translatable="false">@string/title_none</string>
     <string name="pref_gesture_action_left_click">Left-click</string>
+    <string name="pref_gesture_action_left_press">Long-press</string>
     <string name="pref_gesture_action_middle_click">Middle-click</string>
     <string name="pref_gesture_action_right_click">Right-click</string>
     <string name="pref_gesture_action_double_click">Double-click</string>