Bugfix: add missing taskData when retrieving all descriptors

h2zero · Feb 7, 2025 · 2f3dc3a · 2f3dc3a
1 parent 5179398
commit 2f3dc3a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/NimBLERemoteCharacteristic.cpp b/src/NimBLERemoteCharacteristic.cpp
@@ -176,8 +176,10 @@ NimBLERemoteDescriptor* NimBLERemoteCharacteristic::getDescriptor(const NimBLEUU
  */
 const std::vector<NimBLERemoteDescriptor*>& NimBLERemoteCharacteristic::getDescriptors(bool refresh) const {
     if (refresh) {
+        NimBLETaskData         taskData(const_cast<NimBLERemoteCharacteristic*>(this));
+        NimBLEDescriptorFilter filter = {nullptr, nullptr, &taskData};
         deleteDescriptors();
-        retrieveDescriptors();
+        retrieveDescriptors(&filter);
     }
 
     return m_vDescriptors;

diff --git a/src/NimBLERemoteCharacteristic.h b/src/NimBLERemoteCharacteristic.h
@@ -67,7 +67,7 @@ class NimBLERemoteCharacteristic : public NimBLERemoteValueAttribute {
     ~NimBLERemoteCharacteristic();
 
     bool setNotify(uint16_t val, notify_callback notifyCallback = nullptr, bool response = true) const;
-    bool retrieveDescriptors(NimBLEDescriptorFilter* filter = nullptr) const;
+    bool retrieveDescriptors(NimBLEDescriptorFilter* filter) const;
 
     static int descriptorDiscCB(
         uint16_t connHandle, const ble_gatt_error* error, uint16_t chrHandle, const ble_gatt_dsc* dsc, void* arg);