Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "⬆️ Update cdr/code-server to v4.97.2 (#927)" #930

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

frenck
Copy link
Member

@frenck frenck commented Feb 20, 2025

This reverts commit 7e23ab4.

It breaks everything 🗡️

See; coder/code-server#7212

Summary by CodeRabbit

  • Chores
    • Updated the underlying server component to version v4.96.4 to ensure consistent installation and runtime behavior. No user-facing features have changed with this update.

@frenck frenck added the dependencies Upgrade or downgrade of project dependencies. label Feb 20, 2025
Copy link

coderabbitai bot commented Feb 20, 2025

Walkthrough

The Dockerfile in the vscode directory has been updated to change the CODE_SERVER_VERSION argument. The version was changed from "v4.97.2" to "v4.96.4", which affects the download and extraction step for the code server. No other modifications to dependency installation, configuration, or error handling were made.

Changes

File Change Summary
vscode/Dockerfile Updated the CODE_SERVER_VERSION from "v4.97.2" to "v4.96.4".

Sequence Diagram(s)

(No sequence diagrams generated as the changes do not alter any control flow.)

Poem

Hoppin' through code with a spring in my step,
I nibbled on changes and took a quick rep.
Version switched in the Docker delight,
From new to slightly old, it’s still just right.
Carrot cheers and bunny leaps all night!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 00ec141 and 2b6deef.

📒 Files selected for processing (1)
  • vscode/Dockerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build aarch64
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build aarch64
🔇 Additional comments (1)
vscode/Dockerfile (1)

23-23: Revert Code-Server Version Update

The update restores the previous stable version by setting ARG CODE_SERVER_VERSION="v4.96.4", which aligns with the PR objective of reverting the problematic update. Verify that downstream steps—especially the URL construction on line 60 using ${CODE_SERVER_VERSION#v}—resolve correctly with the reverted version tag.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck frenck merged commit 55bcb13 into main Feb 20, 2025
20 checks passed
@frenck frenck deleted the frenck-2025-0101 branch February 20, 2025 11:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant