Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce unresponsive hawtio and possible solution #23

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

saiello
Copy link

@saiello saiello commented Jun 11, 2021

I changed the pre boot task registration to make it works, but I have to revert it

@saiello saiello changed the title WIP: Reproduce unresponsive hawtio and possible solution Reproduce unresponsive hawtio and possible solution Jun 11, 2021
@saiello saiello marked this pull request as ready for review June 11, 2021 11:59
@tadayosi
Copy link
Member

Can you please write an issue first?

@tadayosi tadayosi closed this Nov 16, 2021
@tadayosi
Copy link
Member

Sorry, I found the issue filed already. Just reopen it.

@tadayosi tadayosi reopened this Nov 16, 2021
@saiello saiello force-pushed the reproduce-unresponsive-hawtio branch from 4444b2d to 1f969ef Compare April 6, 2022 08:46
@saiello
Copy link
Author

saiello commented Apr 6, 2022

Hi, @tadayosi since last time I used the console the bug is still present. A simple work around is to limit the keepaliveInterval avoiding the continuous firing of XHR by the ng-interval module.

I resolve any conflict and push the fix again.

@tadayosi
Copy link
Member

tadayosi commented Apr 7, 2022

#22

@tadayosi
Copy link
Member

tadayosi commented Apr 7, 2022

@saiello Thanks for your pull req. Let me understand why it fixes the issue of unresponsiveness.

The root cause seems to be the $interval of angularJS with very high interval value.
In this case keepalive has been started with an interval value of ~15768000 ( 63072000 / 4 ).

  1. Why does having a high value with $interval cause the unresponsiveness? Having a high interval sounds rather more harmless to me.
  2. About the cap number 60. The default interval of ng-idle is 10 * 60. What about using the ng-idle default 10 * 60 instead of 60? Or as it should work as a max limit cap, maybe we can choose a higher value such as 1 * 60 * 60.

@saiello
Copy link
Author

saiello commented Apr 9, 2022

@tadayosi I open a issue on ng-idle as well grbsk/ng-idle#231.

  1. Why does having a high value with $interval cause the unresponsiveness? Having a high interval sounds rather more harmless to me.

Having a value higher than 15032385 make the KeepAlive component to have an unexpected behaviour. It starts continuously firing the event.

  1. About the cap number 60. The default interval of ng-idle is 10 * 60. What about using the ng-idle default 10 * 60 instead of 60? Or as it should work as a max limit cap, maybe we can choose a higher value such as 1 * 60 * 60.

It's ok to increase at a higher value as long as it is less than or equal to 15032385.

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for your explanation. I'll merge it then.

@tadayosi tadayosi merged commit 4cc70be into hawtio:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants