Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mac OS Ventura 13.2 for the M1 (ARM64 platform) #47

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

bdurrani
Copy link
Contributor

@bdurrani bdurrani commented Feb 24, 2023

Changes

As discussed in #46

libmagic was build using file-5.41 built on a M1 running Ventura (13.2)
via the following commands

autoreconf -f -i
./configure --disable-silent-rules
make -j4

I had to add ARM64 solution configurations to get msbuild to pick the correct native library.

Unit Test output

I love how the -p option for dotnet test is not documented. Had to dig around some older issues to find the correct spell

Mime/test/MimeTests on  add-osx-arm64-support [!] via .NET v7.0.200 🎯 net6.0 took 147ms
at 16:25:51 ❯ dotnet test -p:Platform=arm64
  Determining projects to restore...
  Restored /Users/bilal.durrani/github/forks/Mime/src/Mime/Mime.csproj (in 167 ms).
  Restored /Users/bilal.durrani/github/forks/Mime/test/MimeTests/MimeTests.csproj (in 167 ms).
  Mime -> /Users/bilal.durrani/github/forks/Mime/src/Mime/bin/arm64/Debug/netstandard2.0/Mime.dll
  MimeTests -> /Users/bilal.durrani/github/forks/Mime/test/MimeTests/bin/arm64/Debug/net6.0/MimeTests.dll
  IsWindows
  IsOSX true
  IsLinux
  IsArm64 true
  IsX64
Test run for /Users/bilal.durrani/github/forks/Mime/test/MimeTests/bin/arm64/Debug/net6.0/MimeTests.dll (.NETCoreApp,Version=v6.0)
Microsoft (R) Test Execution Command Line Tool Version 17.5.0 (arm64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:    19, Skipped:     0, Total:    19, Duration: 24 ms - MimeTests.dll (net6.0)

@hey-red hey-red merged commit 50c729c into hey-red:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants