Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #709 render component controls prop only for valid types #733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pdmshrestha
Copy link

@pdmshrestha pdmshrestha commented Jun 19, 2024

Description

This fixes the issue if the component prop is not valid types string | number | boolean | object . Some vuetify components have prop type of symbol which is not valid for histoire controls. (unless we want to support it).

Additional context

#709


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

codesandbox bot commented Jun 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Jun 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 6cb9d43
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/66734060b1a99900087dcf4b
😎 Deploy Preview https://deploy-preview-733--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 6cb9d43
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/66734060cd502500084645b5
😎 Deploy Preview https://deploy-preview-733--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 6cb9d43
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/6673406082acd400081ea22c
😎 Deploy Preview https://deploy-preview-733--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 6cb9d43
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/667340601c88920008563a50
😎 Deploy Preview https://deploy-preview-733--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant