Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): do not auto-import idle callback polyfills #777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielroe
Copy link
Collaborator

Description

Not quite sure why/when this popped up but noticed it failing in CI.

We hope to add an option to more easily configure this in Nuxt itself via nuxt/nuxt#30332.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@danielroe danielroe requested a review from Akryum January 15, 2025 15:08
@danielroe danielroe self-assigned this Jan 15, 2025
Copy link

codesandbox bot commented Jan 15, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Jan 15, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for histoire-site failed.

Name Link
🔨 Latest commit 128e591
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/6787cf8db1b4280008c6c643

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for histoire-examples-vue3 failed.

Name Link
🔨 Latest commit 128e591
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/6787cf8d495b810008f6f84f

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for histoire-examples-svelte3 failed.

Name Link
🔨 Latest commit 128e591
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/6787cf8dc306dc000847f217

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit 128e591
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/6787cf8d34c1c30008bf8ff9

Copy link

pkg-pr-new bot commented Jan 15, 2025

Open in Stackblitz

histoire

npm i https://pkg.pr.new/histoire-dev/histoire@777

@histoire/app

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/app@777

@histoire/plugin-nuxt

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-nuxt@777

@histoire/controls

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/controls@777

@histoire/plugin-percy

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-percy@777

@histoire/plugin-screenshot

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-screenshot@777

@histoire/plugin-svelte

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-svelte@777

@histoire/plugin-vue

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/plugin-vue@777

@histoire/shared

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/shared@777

@histoire/vendors

npm i https://pkg.pr.new/histoire-dev/histoire/@histoire/vendors@777

commit: 128e591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant