Add some more sentences to NL Broadcast intent. #2933
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @marcelveldt |
TheFes
requested changes
Jan 30, 2025
| @@ -5,3 +5,5 @@ intents: | |||
| - sentences: | |||
| - "broadcast [overal] [dat] {message}" | |||
| - "roep [overal] ([dat] {message};om)" | |||
| - "roep om [in het huis] {message}" | |||
There was a problem hiding this comment.
if you add an optional [dat] you can say
roep om in het huis dat we gaan eten and it will broadcast we gaan eten
It makes the sentence more natural, and the dat part won't be included in the broadcast message. Without the optional dat it will broadcast dat we gaan eten
There was a problem hiding this comment.
You can combine the 2nd and 3rd one in
- roep [overal|in het huis] ([dat] {message};om)
That will also match
- roep in het huis [dat] {message} om
- roep in het huis om [dat] {message}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few more sentences to the NL/Dutch version of the broadcast intent, these are commonly used on Google Home and Apple Home.