Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: issue of shipment method button being disabled in the reroute-config card(#485) #487

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented Jan 17, 2025

Related Issues

#485

Short Description and Why It's Useful

  • As we have multiple configs to be fetched and the viewSize is harcoded resulting in skipping some of the records
  • Updated the code to make the viewSize dymanic based on number of configs to be fetched
  • Improved shipment method label when no carrier is selected and added placeholder for carrier select option

Screenshots of Visual Changes before/after (If There Are Any)

Before: (when no carrier is selected)

image

After: (when no carrier is selected)

image

Contribution and Currently Important Rules Acceptance

…config card(hotwax#485)

As we have multiple configs to be fetched and the viewSize is harcoded resulting in skipping some of the records
Updated the code to make the viewSize dymanic based on number of configs to be fetched
@ymaheshwari1 ymaheshwari1 merged commit 0d710b5 into hotwax:main Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant