Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created a new service to cancel sales order item and related services #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Created a new service to cancel sales order item and related services #2

wants to merge 4 commits into from

Conversation

vyasdevanshu
Copy link

Implemented: Created a new service CancelSalesOrderItem to cancel an order item in OFBiz and added related services.

Requirement Document link: https://github.com/saastechacademy/foundation/blob/main/project-ideas/order-ledger/cancelSalesOrder.md

@vyasdevanshu
Create OrderServices.xml
868ad90 
Implemented: Created a new service CancelSalesOrderItem to cancel an order item in OFBiz and added related services.
@vyasdevanshu
Copy link
Author

vyasdevanshu commented Nov 27, 2024 •
edited
Loading

There are 2 comments from @dixitdeepak

  • I think we don't need shipGroupSeqId as in parameters. OrderItem entity has the shipGroupSeqId
  • We can utilize the groovy utilities here, eg.
    <set field="quantityTotal" from="shipmentItemSourceList*.quantity.sum()"/>

The other Pull request was closed so posting them here.

@vyasdevanshu
Made improvements in the service implementation
863b928 
- Removed extra logs from the service.
- Corrected the item sales tax total calculation and service call.
- Added some TODOs for future purposes.
@vyasdevanshu
Improveed: Updated OrderServices.xml for some code improvements.
9224882
@vyasdevanshu vyasdevanshu requested a review from janvi04 December 17, 2024 13:14
@vyasdevanshu
Improved: Updated the OrderServices.xml services by adding proper des…
5317430 
…criptions, improving the return statements based on our guidelines and some minor code improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixitdeepak dixitdeepak dixitdeepak left review comments

@janvi04 janvi04 Awaiting requested review from janvi04

Assignees

@mridulpathak mridulpathak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasdevanshu @dixitdeepak @mridulpathak