Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all collection properties are stubbed with common packages #35

Open
mfen opened this issue Oct 30, 2019 · 1 comment
Open

Not all collection properties are stubbed with common packages #35

mfen opened this issue Oct 30, 2019 · 1 comment

Comments

@mfen
Copy link

mfen commented Oct 30, 2019

Our tests began failing as stubbed collections weren't being cleared on restore(). Digging, we found that at the point of parsing collection symbols to stub it was only capturing the own properties from common packages extending Mongo.Collection, e.g. matb33:meteor-collection-hooks.

This looks like #11 again, which was solved with #13 but later undone by cleanup in 376eff1

Will submit a PR to restore the fix.
@mfen mfen mentioned this issue Oct 30, 2019
Open
@shailee-m shailee-m mentioned this issue Mar 18, 2020
Closed
@brylie
Copy link

brylie commented Mar 20, 2020

Any status update for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brylie @mfen