Feat/improve theming #1462
Merged
Feat/improve theming #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the theming system by simplifying window transparency and removing scroll-based animations in the game details view.
- Changed title bar overlay in
/src/main/services/window-manager.tsto be fully transparent (#00000000) for main window - Removed scroll-based sticky header behavior and animation logic from
/src/renderer/src/pages/game-details/hero/hero-panel.tsx - Added theme import modal state management and cleanup in
/src/renderer/src/pages/settings/aparence/settings-appearance.tsx - Fixed backdrop opacity handling in game details view to use static values instead of scroll-based calculations
💡 (4/5) You can add custom instructions or style guidelines for the bot here!
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
zamitto
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.