Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazy loading messing up custom css #1465

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

zamitto
Copy link
Collaborator

@zamitto zamitto commented Feb 19, 2025

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR addresses issues with custom CSS handling and lazy loading in the Hydra launcher application. Here's a concise summary of the key changes:

  • Removed lazy loading from route components in main.tsx to ensure proper CSS loading, trading off initial load performance for consistent styling
  • Simplified CSS injection logic in app.tsx by removing conditional check around injectCustomCss
  • Added state reset for hasShownModal in settings-appearance.tsx to fix theme import modal behavior
  • Fixed theme import functionality to properly handle modal state and CSS injection timing

Key points to review:

  • Verify that removing lazy loading doesn't significantly impact initial load times
  • Ensure CSS injection works consistently across all themes and components
  • Confirm theme import modal behaves correctly after state management changes
  • Test CSS application timing across different navigation scenarios

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@thegrannychaseroperation thegrannychaseroperation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zamitto zamitto merged commit 260a11b into main Feb 19, 2025
4 checks passed
@zamitto zamitto deleted the fix/lazy-loading-messing-up-custom-css branch February 19, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants