Add isFinished to rn-playback event #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyochan
requested changes
Jun 9, 2024
Sure, but can you explain the name a bit? I'm not sure what "changed" is referring to in this context. Does it mean the playback state has changed from playing to finished? |
Oh I am so sorry. I meant 
Let me merge this! |
hyochan
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to support chunked transfer-encoded HTTP requests, such as those returned from OpenAI and ElevenLabs Text-to-speech APIs.
Since these http requests don't contain a content-length, we can't rely on the duration to determine when they have finished.