Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *.tsbuildinfo files (TypeScript build cache) to .gitignore #187

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

robertknight
Copy link
Member

These files started appearing after updating to TypeScript 5.6. See hypothesis/h#8992.

These files started appearing after updating to TypeScript 5.6. See
hypothesis/h#8992.
@robertknight robertknight requested a review from seanh October 28, 2024 12:21
Copy link
Contributor

@seanh seanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially make this conditional and only add it to projects that have a frontend ({% if cookiecutter.get("frontend") == "yes" %}) but that hasn't been done for other frontend-related files in .gitignore and it's probably not worthwhile doing. One benefit would be creating fewer automated PRs after merging this one, as it won't add this to every single Python project. Nonetheless, I say just merge this as-is 👍

@robertknight robertknight merged commit 819732a into main Oct 29, 2024
4 checks passed
@robertknight robertknight deleted the tsbuildinfo-ignore branch October 29, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants