Skip to content

Commit

Permalink
test(risingwave): relax dtype check
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Feb 12, 2025
1 parent 15111f8 commit 3e0a864
Showing 1 changed file with 11 additions and 12 deletions.
23 changes: 11 additions & 12 deletions ibis/backends/tests/test_join.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,11 @@ def check_eq(left, right, how, **kwargs):
[
"inner",
"left",
param(
"right",
marks=[sqlite_right_or_full_mark],
),
param(
"outer",
# TODO: mysql will likely never support full outer join
# syntax, but we might be able to work around that using
# LEFT JOIN UNION RIGHT JOIN
marks=sqlite_right_or_full_mark,
),
param("right", marks=[sqlite_right_or_full_mark]),
# TODO: mysql will likely never support full outer join
# syntax, but we might be able to work around that using
# LEFT JOIN UNION RIGHT JOIN
param("outer", marks=sqlite_right_or_full_mark),
],
)
@pytest.mark.notimpl(["druid"])
Expand Down Expand Up @@ -100,7 +94,12 @@ def test_mutating_join(backend, batting, awards_players, how):
.reset_index(drop=True)
)

backend.assert_frame_equal(result, expected, check_like=True)
backend.assert_frame_equal(
result,
expected,
check_like=True,
check_dtype=not (how == "right" and backend.name() == "risingwave"),
)


@pytest.mark.parametrize("how", ["semi", "anti"])
Expand Down

0 comments on commit 3e0a864

Please sign in to comment.