Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ac replayer #59

Merged
merged 45 commits into from
Aug 19, 2024
Merged

Ac replayer #59

merged 45 commits into from
Aug 19, 2024

Conversation

Petingo
Copy link
Collaborator

@Petingo Petingo commented Jun 11, 2024 •
edited
Loading

Description 🤖

This is the pull request for the AC-replayer GH components.

  • Replayer Initialization GH Component
    • Aggregate multiple log sequence
    • Auto download the corresponding version of TTool dataset
    • Producing data for scene reconstruction
      • Object pose (transformation)
      • ACIM status
      • Tool status
  • Scene reconstruction
    • Thickness of the blade
  • Geometry primitive of the blades and drill-bit (chainsaw is optional for now since not in use)
  • Minimal demostration of the componentized script in GH
  • Component for generating the final video (params: beginning & end frame, fps)

WIP to be fix:

  • Dealing with missing TTool version
  • It takes quite long to load all TTools. It might be able to improve.

Type of feature/changes 🌲

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@Petingo Petingo self-assigned this Jun 27, 2024
@Petingo
Copy link
Collaborator Author

Petingo commented Jun 30, 2024

I changed the way to build the surface (for cut objects in acim), from PlanarSrf to FragmentPatch. Due to the numerical error (I guess), some of the points on cut surface are not co-planar, and thus PlanarSrf failed to produce a result. FragmentPatch works on non-coplanar points or polylines, but I'm not sure if it will cause problem in the future.

If it really causes some problem, we will need to fix the numerical errors prior to running the surface reconstruction.

@9and3 9and3 marked this pull request as draft July 12, 2024 08:25
@Petingo Petingo marked this pull request as ready for review July 16, 2024 10:48
@9and3
Copy link
Collaborator

9and3 commented Aug 6, 2024

Hello @Petingo ,
What's the stauts on this wonderfull PR? :)
Is the video recorder component finished?

@Petingo
Copy link
Collaborator Author

Petingo commented Aug 7, 2024

There's a bug that the generated log might not contain the TTool version. I'll have to make a patch for this. Otherwise it's done. I'm also composing a table of good / bad record according to the transformation of the acim, either correct / wrong.

@9and3
Copy link
Collaborator

9and3 commented Aug 17, 2024

@Petingo can you please upload the latest commit with the the solve for the bottleneck? (lines to polyline). I am merging this..

@Petingo
Copy link
Collaborator Author

Petingo commented Aug 17, 2024

There's a bug in the code for handling the initial condition that I didn't manage to solve yesterday :(
But as it's just a component on the GH canvas. I think you can merge this one and I'll update the GH file later.

@9and3
Copy link
Collaborator

9and3 commented Aug 18, 2024 •
edited
Loading

There's a bug in the code for handling the initial condition that I didn't manage to solve yesterday :( But as it's just a component on the GH canvas. I think you can merge this one and I'll update the GH file later.

No prob, let's take the time to integrate your changes and fixes on the gh file on the example file as well. Let me know by end of Monday plis, thanks!

9and3
9and3 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@9and3 9and3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello HB, all lokks good, just some left overs that we might have the time to clean..thanks for this PR!

.github/workflows/gh-build.yml
@@ -2,7 +2,7 @@ name: gh-build

on:
push:
branches: ["main"]
branches: ["main", "ac_replayer"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please get rid of ac_replayer

.gitignore
Comment on lines +10 to +11
py/expirment
assets/replayer_example/TTool_dataset
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this from gitignore and directory. Tests should go in temp folder

assets/replayer_example/logs/AC01_2024-07-16-11-00-59/scanned_model.ply Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please same thing remove this

py/components/replayer_image_cleaner/code.py
@@ -0,0 +1,25 @@
"""Grasshopper Script Instance"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

py/components/replayer_initializer/code.py
@@ -0,0 +1,27 @@
"""Grasshopper Script Instance"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

py/components/replayer_scene_generator/code.py
@@ -0,0 +1,30 @@
"""Grasshopper Script Instance"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

py/components/replayer_video_capture/code.py
@@ -0,0 +1,56 @@
"""Grasshopper Script Instance"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

py/pypi/ACPy/replayer/gh_loop.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@9and3 9and3 merged commit 984f120 into main Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9and3 9and3 9and3 approved these changes

Assignees

@Petingo Petingo

Labels
grasshopper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Petingo @9and3