Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: excludePNP nesting in grades query builder #67

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: excludePNP nesting in grades query builder #67

merged 1 commit into from
Jan 9, 2025

Conversation

andrew-wang0
Copy link
Member

@andrew-wang0 andrew-wang0 commented Jan 8, 2025 •
edited
Loading

Description

Related Issue

Closes #66

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code involves a change to the database schema.
  • My code requires a change to the documentation.

@laggycomputer
Copy link
Member

Should this be marked as a bugfix?

@andrew-wang0 andrew-wang0 added bug Something isn't working and removed bug Something isn't working labels Jan 8, 2025
@laggycomputer
Copy link
Member

Looks good in principle, will do local testing soon to verify efficacy of fix

laggycomputer
laggycomputer approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@laggycomputer laggycomputer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is confirmed effective, correctly excluding sections for which no letter grades are recorded regardless of GE filter.

@andrew-wang0 andrew-wang0 merged commit 194b959 into main Jan 9, 2025
@andrew-wang0 andrew-wang0 deleted the grades-query-builder branch January 9, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laggycomputer laggycomputer laggycomputer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect excludePNP nesting in grades query builder
2 participants
@andrew-wang0 @laggycomputer