feat: add web column to WebSoc #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-wang0
temporarily deployed
to
staging-82
GitHub Actions
Inactive
andrew-wang0
temporarily deployed
to
staging-82
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified
libwebsoc-nextto support fetching the Web column, which links to the section's syllabus page, and is realized as thewebURLfield in theWebsocSectionobject.Because this column is not reflected in the XML response, which
libwebsoc-nextparses into JSON, the module also fetches the web version concurrently with the XML version.As a result, the timeouts after WebSoc query invocations in the scraper have been doubled.
Related Issue
Closes #41.
Motivation and Context
Unblocks icssc/AntAlmanac#1113.
How Has This Been Tested?
Tested locally due to schema changes. Database dump available here.
Types of changes
Checklist: