Skip to content

Commit

Permalink
Restore search module slice usage
Browse files Browse the repository at this point in the history
it's best i leave it as is, some unexpected behavior may happen with the
useEffect hooks
  • Loading branch information
js0mmer committed Feb 12, 2024
1 parent 3d80010 commit 702b812
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions site/src/component/SearchModule/SearchModule.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ interface SearchModuleProps {

const SearchModule: FC<SearchModuleProps> = ({ index }) => {
const dispatch = useAppDispatch();
const search = useAppSelector((state) => state.search[index]);
const courseSearch = useAppSelector((state) => state.search.courses);
const professorSearch = useAppSelector((state) => state.search.professors);
let pendingRequest: NodeJS.Timeout | null = null;

const searchNames = useCallback(
Expand Down Expand Up @@ -64,8 +65,13 @@ const SearchModule: FC<SearchModuleProps> = ({ index }) => {

// Refresh search results when names and page number changes
useEffect(() => {
searchResults(index, search.pageNumber, search.names);
}, [index, search.names, search.pageNumber, searchResults]);
searchResults('courses', courseSearch.pageNumber, courseSearch.names);
}, [courseSearch.names, courseSearch.pageNumber, searchResults]);

// Refresh search results when names and page number changes
useEffect(() => {
searchResults('professors', professorSearch.pageNumber, professorSearch.names);
}, [professorSearch.names, professorSearch.pageNumber, searchResults]);

const searchNamesAfterTimeout = (query: string) => {
if (pendingRequest) {
Expand Down

0 comments on commit 702b812

Please sign in to comment.