Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SubReview.tsx #534

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update SubReview.tsx #534

wants to merge 2 commits into from

Conversation

philosolog
Copy link
Member

Description

Screenshots

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #

@philosolog philosolog requested review from js0mmer, timobraz and Awesome-E and removed request for js0mmer December 7, 2024 03:25
@js0mmer js0mmer linked an issue Dec 11, 2024 that may be closed by this pull request
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I go to edit a review, the review text gets updated immediately upon saving, but I have to reload the page before "Updated at [date]" appears

@Awesome-E
Copy link
Member

Awesome-E commented Jan 13, 2025

when you're ready for re-review, don't forget to click this button as well as the "re-request review" button next to "reviewers"
image
image

@charlieweinberger
Copy link

Not sure exactly what the changes are here, but this seems like it'd conflict with my pull request #552, which heavily modifies SubReview.tsx. Just something to keep in mind, although this seems like a minor change that I could easily integrate into my pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save/show timestamp of last review edit
3 participants