feat: fix record size larger than batch size #4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
fix_batch_size_2
branch
4 times, most recently
from
5ac1aa8 to
98b8ee1
Compare
fraidev
changed the title
fraidev
force-pushed
the
fix_batch_size_2
branch
from
98b8ee1 to
d711d12
Compare
fraidev
commented
Sep 26, 2024
fraidev
force-pushed
the
fix_batch_size_2
branch
5 times, most recently
from
c389a59 to
86b114e
Compare
fraidev
force-pushed
the
fix_batch_size_2
branch
3 times, most recently
from
caa9179 to
e8479a3
Compare
digikata
reviewed
Sep 26, 2024
digikata
reviewed
Sep 26, 2024
fraidev
force-pushed
the
fix_batch_size_2
branch
3 times, most recently
from
f1bf7b2 to
f53eeee
Compare
|
should link PR to issue and more detail explanation how should work |
Sure! Should fix #4161 |
fraidev
force-pushed
the
fix_batch_size_2
branch
from
f53eeee to
be8ba8c
Compare
sehz
reviewed
Sep 29, 2024
sehz
reviewed
Sep 29, 2024
sehz
reviewed
Sep 29, 2024
fraidev
force-pushed
the
fix_batch_size_2
branch
2 times, most recently
from
7a39f30 to
97c1bc1
Compare
fraidev
force-pushed
the
fix_batch_size_2
branch
from
a75ca78 to
68d2982
Compare
fraidev
force-pushed
the
fix_batch_size_2
branch
5 times, most recently
from
be1be20 to
04e144d
Compare
fraidev
force-pushed
the
fix_batch_size_2
branch
5 times, most recently
from
678a41f to
c1f6e4e
Compare
fraidev
force-pushed
the
fix_batch_size_2
branch
from
c1f6e4e to
539d7d2
Compare
sehz
requested changes
Oct 15, 2024
fraidev
force-pushed
the
fix_batch_size_2
branch
from
1e6e7cb to
fd7fb17
Compare
fraidev
force-pushed
the
fix_batch_size_2
branch
from
fd7fb17 to
da00b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to instead return an error when a record is bigger than the batch size, create a new batch with this single record without batch size limit.
I also propose adding a config variable called
max_request_size.Also, I removed the
compression_coefficientbeen used to calculate thebatch_size, because I believe that compression should not be related with thebatch_size.Should also fix: #4161