Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fvm): override installed binaries target #4215

Merged
merged 5 commits into from
Oct 19, 2024

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented Oct 17, 2024

Provides support to override the target triple used when fetching binaries from package registry.

Demo

fvm install now accepts the --target option which takes a Rust Target Triple thats used to replace the default target which is host's OS target.

Alternately a user could specify FVM_BINARY_ARCH_TRIPLE environment variable, used for the same purpose. This is useful for CI environments.

help

If the target triple is not available, FVM will notify the user before performing any further tasks.

fvm install latest --target aarch64-unknown-linux-gnu
Error: PackageSet "latest" is not available for architecture: "aarch64-unknown-linux-gnu"

bad-target

@EstebanBorai EstebanBorai requested review from digikata and sehz October 18, 2024 00:20
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you also set the INFINYON_CI_CONTEXT for fvm tests?

@EstebanBorai
Copy link
Contributor Author

LGTM, could you also set the INFINYON_CI_CONTEXT for fvm tests?

Of course!

@EstebanBorai EstebanBorai force-pushed the feat/fvm-target-override branch from 6b5f822 to 81d9c16 Compare October 18, 2024 19:37
@EstebanBorai EstebanBorai added this pull request to the merge queue Oct 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 19, 2024
@EstebanBorai EstebanBorai added this pull request to the merge queue Oct 19, 2024
Merged via the queue into master with commit 8efca9d Oct 19, 2024
106 checks passed
@EstebanBorai EstebanBorai deleted the feat/fvm-target-override branch October 19, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants