Testes para o fluxo do quiz #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Silva <[email protected]>
Signed-off-by: Pedro Silva <[email protected]>
- prevent NPE
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 50.26% 52.41% +2.15%
==========================================
Files 487 487
Lines 14546 14556 +10
==========================================
+ Hits 7312 7630 +318
+ Misses 7234 6926 -308 ☔ View full report in Codecov by Sentry. |
- fix GuardianTutorialPage pop result - ensure pop result to be true in QuizShowStealthTutorialWidget and QuizShowHelpTutorialWidget - Fix message feedback after reply when type is displayTextResponse Signed-off-by: Pedro Silva <[email protected]>
pedrox-hs
force-pushed
the
improvements/quiz/increase-tests
branch
from
3084d63 to
c26be05
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
- inject instance of AppNavigator - define default values for QuizSessionEntity - replace MediaQuery with LayoutBuilder in QuizButtonYesNoWidget - Make QuizPageState public Signed-off-by: Pedro Silva <[email protected]>
- Make screenshotTest's devices param not nullable - Add ValueKey to GoldenTestWidgetApp - Reset Modular route information between tests with buildTestableApp - Add helper to interact with page's controller - Improve tapAll to find exact element to avoid errors with const widgets Signed-off-by: Pedro Silva <[email protected]>
Signed-off-by: Pedro Silva <[email protected]>
pedrox-hs
force-pushed
the
improvements/quiz/increase-tests
branch
from
c26be05 to
1197ad0
Compare
Signed-off-by: Pedro Silva <[email protected]>
pedrox-hs
force-pushed
the
improvements/quiz/increase-tests
branch
from
1197ad0 to
140533f
Compare
|
|
Code Climate has analyzed commit 140533f and detected 6 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
pedrox-hs
commented
Feb 23, 2024
lib/app/features/help_center/presentation/pages/tutorial/guardian/guardian_tutorial_page.dart
Show resolved
Hide resolved
pedrox-hs
temporarily deployed
to
firebase-distribution
GitHub Actions
Inactive
pedrox-hs
temporarily deployed
to
firebase-distribution
GitHub Actions
Inactive
diraol
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O objetivo principal é garantir que as interações estejam testadas, com isso foram necessários alguns ajustes para melhorar a testabilidade buscando minimizar o impacto das alterações e também foi encontrados possíveis bugs.
PS.: dos arquivos "alterados" exatamente a metade (21) são de arquivos de imagens gerados pelos testes.