Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remover dependência do Modular ZodiacPage #384

Merged
merged 3 commits into from
Jan 13, 2025
Merged

[refactor] Remover dependência do Modular ZodiacPage #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a50453e
refactor: remover dependência do Modular na ZodiacPage
shonorio Jan 12, 2025
e3a70ce
refactor: ajustar injeção do ZodiacController no ZodiacModule
shonorio Jan 12, 2025
d4573c1
refactor: remover dependência do Modular nos testes da ZodiacPage
shonorio Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/app/features/zodiac/presentation/zodiac_module.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,5 @@ class ZodiacModule extends WidgetModule {
];

@override
Widget get view => const ZodiacPage();
Widget get view => ZodiacPage(controller: Modular.get<ZodiacController>());
}
13 changes: 7 additions & 6 deletions lib/app/features/zodiac/presentation/zodiac_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import 'package:flutter/material.dart';
import 'package:flutter_mobx/flutter_mobx.dart';
import 'package:flutter_modular/flutter_modular.dart';

import '../../../shared/design_system/colors.dart';
import '../../../shared/design_system/logo.dart';
Expand All @@ -13,17 +12,19 @@ import 'zodiac_controller.dart';

class ZodiacPage extends StatefulWidget {
const ZodiacPage({
required this.controller,
Key? key,
this.title = 'ZodiacPage',
}) : super(key: key);

final String title;
final ZodiacController controller;

@override
_ZodiacPageState createState() => _ZodiacPageState();
State<ZodiacPage> createState() => _ZodiacPageState();
}

class _ZodiacPageState extends ModularState<ZodiacPage, ZodiacController> {
class _ZodiacPageState extends State<ZodiacPage> {
ZodiacController get controller => widget.controller;

@override
void dispose() {
controller.dispose();
Expand Down Expand Up @@ -82,7 +83,7 @@ class _ZodiacPageState extends ModularState<ZodiacPage, ZodiacController> {
),
onPressed: () => controller.forwardStealthLogin(),
child: const Text(
'Diário astrólogico',
'Diário astrológico',
style: kTextStyleFeedTweetShowReply,
),
),
Expand Down
30 changes: 12 additions & 18 deletions test/app/features/zodiac/presentation/zodiac_page_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import 'package:flutter/material.dart';
import 'package:flutter_modular/flutter_modular.dart';
import 'package:flutter_modular_test/flutter_modular_test.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:mocktail/mocktail.dart';
import 'package:penhas/app/features/appstate/domain/entities/user_profile_entity.dart';
Expand All @@ -9,7 +7,6 @@ import 'package:penhas/app/features/zodiac/presentation/pages/zodiac_felling_pag
import 'package:penhas/app/features/zodiac/presentation/pages/zodiac_ruling_page.dart';
import 'package:penhas/app/features/zodiac/presentation/pages/zodiac_sign_page.dart';
import 'package:penhas/app/features/zodiac/presentation/zodiac_controller.dart';
import 'package:penhas/app/features/zodiac/presentation/zodiac_module.dart';
import 'package:penhas/app/features/zodiac/presentation/zodiac_page.dart';

import '../../../../utils/golden_tests.dart';
Expand All @@ -18,6 +15,8 @@ import '../../authentication/presentation/mocks/app_modules_mock.dart';
import '../../authentication/presentation/mocks/authentication_modules_mock.dart';

void main() {
late ZodiacController controller;

setUp(() {
AppModulesMock.init();
AuthenticationModulesMock.init();
Expand Down Expand Up @@ -45,25 +44,20 @@ void main() {

when(() => AuthenticationModulesMock.securityAction.dispose())
.thenAnswer((_) => Future.value());
initModule(ZodiacModule(), replaceBinds: [
Bind.factory((i) => ZodiacController(
userProfileStore: AppModulesMock.userProfileStore,
securityAction: AuthenticationModulesMock.securityAction,
)),
]);
});

tearDown(() {
Modular.removeModule(ZodiacModule());
controller = ZodiacController(
userProfileStore: AppModulesMock.userProfileStore,
securityAction: AuthenticationModulesMock.securityAction,
);
});

group(ZodiacPage, () {
testWidgets('should render the page', (tester) async {
// arrange
await theAppIsRunning(tester, const ZodiacPage());
await theAppIsRunning(tester, ZodiacPage(controller: controller));
// assert
iSeeText('Hoje');
iSeeText('Diário astrólogico');
iSeeText('Diário astrológico');
iSeeWidget(ZodiacSignPage);
iSeeWidget(ZodiacRulingPage);
iSeeWidget(ZodiacFellingPage);
Expand All @@ -76,9 +70,9 @@ void main() {
when(() =>
AppModulesMock.modularNavigator.pushReplacementNamed(routeName))
.thenAnswer((_) => Future.value());
await theAppIsRunning(tester, const ZodiacPage());
await theAppIsRunning(tester, ZodiacPage(controller: controller));
// act
await iTapText(tester, text: 'Diário astrólogico');
await iTapText(tester, text: 'Diário astrológico');
// assert
verify(() =>
AppModulesMock.modularNavigator.pushReplacementNamed(routeName))
Expand All @@ -93,7 +87,7 @@ void main() {
.thenAnswer((_) => Future.value());
when(() => AuthenticationModulesMock.securityAction.stop())
.thenAnswer((_) => Future.value());
await theAppIsRunning(tester, const ZodiacPage());
await theAppIsRunning(tester, ZodiacPage(controller: controller));
await tester.pumpAndSettle();
// act
await iSeeWidget(ZodiacActionButton);
Expand All @@ -106,7 +100,7 @@ void main() {
screenshotTest(
'should render the page',
fileName: 'zodiac_page',
pageBuilder: () => const ZodiacPage(),
pageBuilder: () => ZodiacPage(controller: controller),
);
});
}
Loading