Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remover dependência do Modular ChatMainPeoplePage #393

Merged

Conversation

RoxyRoses
Copy link
Contributor

@RoxyRoses RoxyRoses commented Jan 13, 2025

Refatoração: Injeção de Dependências no ChatMainPage e ChatMainPeoplePage

Descrição

Este pull request refatora a forma como os controladores são injetados no ChatMainPage e no ChatMainPeoplePage, eliminando o uso de ModularState e adotando injeção explícita por meio de construtores. Isso melhora a testabilidade e modularidade do código, além de reduzir o acoplamento com o framework Modular.


Alterações Realizadas

1. Atualização no ChatMainPage

  • Adicionado um parâmetro obrigatório chatMainPeopleController ao construtor.
  • Modificado o uso do ModularState para acessar o controlador via widget, tornando a dependência explícita.

Antes:

class ChatMainPage extends StatefulWidget {
  const ChatMainPage({Key? key}) : super(key: key);

  @override
  _ChatMainPageState createState() => _ChatMainPageState();
}

class _ChatMainPageState
    extends ModularState<ChatMainPage, ChatMainController> {
  @override
  Widget build(BuildContext context) {
    return Observer(
      ...
    );
  }
}

Depois

class ChatMainPage extends StatefulWidget {
  const ChatMainPage({Key? key, required this.chatMainPeopleController})
      : super(key: key);

  final ChatMainPeopleController chatMainPeopleController;

  @override
  _ChatMainPageState createState() => _ChatMainPageState();
}

class _ChatMainPageState extends State<ChatMainPage> {
  ChatMainPeopleController get chatMainPeopleController =>
      widget.chatMainPeopleController;

  @override
  Widget build(BuildContext context) {
    return Observer(
      ...
    );
  }
}

@RoxyRoses RoxyRoses added deprecation Para destacar o uso de componentes obsoletos refactor Envolve melhorias no código, como substituir o componentes obsoletos labels Jan 13, 2025
@RoxyRoses RoxyRoses self-assigned this Jan 13, 2025
@RoxyRoses RoxyRoses requested a review from a team as a code owner January 13, 2025 17:19
@RoxyRoses RoxyRoses linked an issue Jan 13, 2025 that may be closed by this pull request
… into 367-substituir-modularstate-por-state-em-chatmainpeoplepage
Copy link

codeclimate bot commented Jan 14, 2025

Code Climate has analyzed commit ddcd83c and detected 0 issues on this pull request.

View more on Code Climate.

@shonorio shonorio merged commit 89d167d into main Jan 14, 2025
8 checks passed
@shonorio shonorio deleted the 367-substituir-modularstate-por-state-em-chatmainpeoplepage branch January 14, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Para destacar o uso de componentes obsoletos refactor Envolve melhorias no código, como substituir o componentes obsoletos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Substituir ModularState por State em ChatMainPeoplePage
2 participants