Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-18004][Student] Fix file list network call #2798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MBL-18004][Student] Fix file list network call #2798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/student/src/main/java/com/instructure/student/features/files/list/FileListFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import androidx.appcompat.app.AlertDialog
import androidx.appcompat.widget.PopupMenu
import androidx.core.content.FileProvider
import androidx.lifecycle.LiveData
import androidx.lifecycle.lifecycleScope
import androidx.work.WorkInfo
import androidx.work.WorkManager
import com.instructure.canvasapi2.managers.FileFolderManager
Expand All @@ -47,6 +48,7 @@ import com.instructure.canvasapi2.utils.pageview.PageViewUrl
import com.instructure.canvasapi2.utils.pageview.PageViewUtils
import com.instructure.canvasapi2.utils.weave.awaitApi
import com.instructure.canvasapi2.utils.weave.catch
import com.instructure.canvasapi2.utils.weave.tryLaunch
import com.instructure.canvasapi2.utils.weave.tryWeave
import com.instructure.interactions.bookmarks.Bookmarkable
import com.instructure.interactions.bookmarks.Bookmarker
Expand Down Expand Up @@ -185,7 +187,7 @@ class FileListFragment : ParentFragment(), Bookmarkable, FileUploadDialogParent
if (folder != null) {
configureViews()
} else {
tryWeave {
lifecycleScope.tryLaunch {
folder = if (folderId != 0L) {
// If folderId is valid, get folder by ID
fileListRepository.getFolder(folderId, true)
Expand Down