Navigation bar titles

[rh12]

refs: MBL-18460
affects: Student, Teacher, Parent
release note: none

What's changed

• Unified navigation bar title/subtitle SwiftUI implementations
  • into InstUI.NavigationBarTitleView, it's used via navigationBarTitleView()
  • it works in SwiftUI NavigationView too, not just in UINavigationController
  • it supports VoiceOver properly
  • Updated all SwiftUI screens to use this one
• Kept UIKit solution TitleSubtitleView, but now it is only used in ViewControllers
• Updated title font to semibold16 and subtitle font to regular14

How to set navigation bar title/subtitle

• call navigationBarTitleView(_:) or navigationBarTitleView(title:, subtitle:) modifier
• AFTERWARDS call navigationBarStyle(_:) modifier
• don't use the native navigationTitle() methods

Chores

• removed deprecated method calls
• removed unused Inbox AttachmentPicker
• removed leftover .modalLight navigation bar style
• move related files under CommonUI/NavigationBar folder

Test Plan

• Verify the following screens' navigation title view reads out "[title], [subtitle], Heading" in VoiceOver
  • Student: Assignment Details screen
  • Student: Grade List Preferences screen
  • Parent: Grade List Preferences screen
• Verify CourseDetails screen nav bar works properly together with Smart Search
• Verify various kind of screens open properly in Modules (or at least as close to properly as before)
• Smoke test nav bars on some screens (see "Files changed" tab)

Checklist

• A11y checked
• Tested on phone @ iOS 18
• Tested on phone @ iOS 17
• Tested on tablet @ iOS 18
• Tested on tablet @ iOS 17
• Tested in dark mode
• Tested in light mode
• Approve from product

[inst-danger]

Teacher Build QR Code:

[inst-danger]

Parent Build QR Code:

[inst-danger]

Student Build QR Code:

[inst-danger]

	Warnings
⚠️	This pull request will not generate a release note.

Affected Apps: Student, Teacher, Parent

MBL-18460

Coverage	New %	Master %	Delta
Canvas iOS	91.68%	91.52%	0.16%

Generated by 🚫 dangerJS against bc5726c

[suhaibabsi-inst]

This is considered as being an implicit dependency and can be easily missed out.
Rather than dictating that a specific modifier must be called after this one for it work properly.
I would go with passing style as a required parameter to this modifier.

[rh12]

I agree that it's not ideal, and I've considered passing style here, but it creates it's own problems.
Style sets the background color as well, and as a next step it's planned to govern the NavigationBarItems' color (via navBarColors.tint). That would mean we would have to set the style in 3 separate places which is also not ideal, plus it allows for mixed styles which we want to restrict.

I consider this solution as a lesser evil. And since order already matters for SwiftUI modifiers, it's a known concept (although maybe in an unexpected way, yes). Another mitigation of the issue is that this solution (and only this) would be used all over the project, with plenty of examples and documentation.

[suhaibabsi-inst]

Just to make sure I conveyed my idea correctly. What I mean with passing style, as simple as having style modifier inside this one.

    public func navigationBarTitleView(title: String, subtitle: String?, style: NavigationBarStyle) -> some View {
        toolbar {
            ToolbarItem(placement: .principal) {
                InstUI.NavigationBarTitleView(title: title, subtitle: subtitle)
            }
        }
        .navigationBarStyle(style)
    }

You mean even doing that can create problems ?

[rh12]

Yes, basically I aim to avoid this:

content
    .navigationBarTitleView(title: ..., style: .modal)
    .navBarItems(trailing: ..., style: .modal)
    .navigationBarStyle(.modal)

or even:

content
    .navigationBarTitleView(title: ..., style: .modal)
    .navBarItems(trailing: ..., style: .modal) // which would call .navigationBarStyle() inside again in your example

[suhaibabsi-inst]

Code +1

[suhaibabsi-inst]

No navigationBarStyle() is called after this.

[suhaibabsi-inst]

QA +1

Tested on iPhone, iOS 18.2.0, Student and Parent apps.

One note though, I noticed that Title View on Assignments Screen takes a split second before appearing. See record below:

ScreenRecording_02-12-2025.17-34-00_1.MP4