Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long press on rubric #3138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix long press on rubric #3138

wants to merge 1 commit into from
+6 −8

Conversation

vargaat
Copy link
Collaborator

@vargaat vargaat commented Feb 12, 2025 •
edited by suhaibabsi-inst
Loading

What's new?

  • We used a deprecated long press method on rubric views that no longer works on iOS 18. I updated to use an up-to-date version of this method.
  • I also added a fade animation to the already existing scale animation so when using an Apple pencil it's no longer visible that the tooltip scales down to a comically small size because it fades out in the meantime.

refs: MBL-18567
affects: Teacher
release note: Fixed long tap gesture on rubric ratings in SpeedGrader.

test plan:

  • As the teacher create an assignment that has a rubric associated to it.
  • Log in to the Canvas Teacher app on an iOS device.
  • Open the assignment.
  • Navigate to the Submissions section and select a student to grade.
  • Swipe up to open the grade details section.
  • Tap and hold on one of the rubric ratings.
  • The rating's title should be revealed.

Checklist

  • Tested on iOS 17
  • Tested on iOS 18

@vargaat
Remove deprecated long press method. Improve appear animation of tool…
5c1b7a8 
…tip.

refs: MBL-18567
affects: Teacher
release note: Fixed long tap gesture on rubric ratings in SpeedGrader.

test plan:
- As the teacher create an assignment that has a rubric associated to it.
- Log in to the Canvas Teacher app on an iOS device.
- Open the assignment.
- Navigate to the Submissions section and select a student to grade.
- Swipe up to open the grade details section.
- Tap and hold on one of the rubric ratings.
- The rating's title should be revealed.
@vargaat vargaat self-assigned this Feb 12, 2025
@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Feb 12, 2025 •
edited by jira bot
Loading

Release Note:

Fixed long tap gesture on rubric ratings in SpeedGrader.

Affected Apps: Teacher

MBL-18567

Coverage New % Master % Delta
Canvas iOS 91.51% 91.52% -0.01%

Generated by 🚫 dangerJS against 5c1b7a8

suhaibabsi-inst
suhaibabsi-inst approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

Tested on iPhone, iOS 18.2.0, Teacher app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhaibabsi-inst suhaibabsi-inst suhaibabsi-inst approved these changes

@szabinst szabinst Awaiting requested review from szabinst szabinst is a code owner

@rh12 rh12 Awaiting requested review from rh12 rh12 is a code owner

@ndrsszsz ndrsszsz Awaiting requested review from ndrsszsz ndrsszsz is a code owner

Assignees

@vargaat vargaat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vargaat @inst-danger @suhaibabsi-inst