-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E2E] Update the current XFAIL status of e2e tests with the SPIR-V Backend #16692
[E2E] Update the current XFAIL status of e2e tests with the SPIR-V Backend #16692
Conversation
Even fresher results:
@aelovikov-intel FYI |
@cperkinsintel can you please have a look |
@intel/dpcpp-sanitizers-review @intel/syclcompat-lib-reviewers Can you please have a look? |
@@ -7,6 +7,9 @@ | |||
// UNSUPPORTED: cpu | |||
// UNSUPPORTED-TRACKER: CMPLRLLVM-64618 | |||
|
|||
// XFAIL: spirv-backend && gpu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this test can work well on "spirv-backend && cpu"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, right, the test case works on cpu but not on gpu. I haven't had a capacity yet to look any closer to a newer e2e test cases, including Memory Sanitizer. It should be very easy for you to look what's the issue, if we are lucky it can be as simple, for example, as CHECK-DAG instead of CHECK. After recent PR's it's easy to switch between Translator and Backend in your local dev environment and reproduce the case. Please let me know if I can help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I will take a look
0b66eee
to
7d23cde
Compare
7d23cde
to
1b61bb2
Compare
This PR updates the current XFAIL status of e2e tests with the SPIR-V Backend to keep CI runs with the SPIR-V Backend green.
Freshly validated by the following workflow runs: