Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Doc] Add test plan for sycl_ext_oneapi_device_image_backend_content extension #16698

Open
wants to merge 17 commits into
base: sycl
Choose a base branch
from

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Jan 20, 2025

This PR adds the test plan for sycl_ext_oneapi_device_image_backend_content extension.

@lbushi25 lbushi25 marked this pull request as ready for review January 20, 2025 19:54
@lbushi25 lbushi25 requested a review from a team as a code owner January 20, 2025 19:54
@lbushi25 lbushi25 requested a review from againull January 20, 2025 19:54

The unit tests should be launched on every supported device configuration we have.

The end-to-end tests, which consist of checking the interoperability with Level Zero
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there going to be test coverage for other backends, like cuda and hip?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit tests will be run on all configurations but the end to end tests will only run on Level Zero and OpenCL because there does not seem to be a well-defined way to retrieve a kernel from a device image executable for other backends.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the plan unit tests will only do some basic API checks but not verify that obtained result is correct.
Is it possible to use module management APIs https://docs.nvidia.com/cuda/cuda-driver-api/group__CUDA__MODULE.html (like cuModuleLoad*) to check the result?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that can be used and I should definitely add that to the test plan. For example, the test should use cuModuleLoadData to load the binary data into a module and verify that CUDA_SUCCESS is returned. We cannot go any further unfortunately as there is no portable way to retrieve our kernel from the module as is the case, for example, with Level Zero(see here). For HIP, the format of the data is not even defined so I don't think there is much to verify there.

@lbushi25 lbushi25 requested a review from a team January 31, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants