Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adjust Image filter #7594

Merged
merged 8 commits into from
Feb 4, 2025

Conversation

dunkeroni
Copy link
Contributor

Summary

Adds a new Canvas filter that exposes the ImageChannelOffsetInvocation and ImageChannelMultiplyInvocation functions.

  • Adjust Image is now the default when opening the Filters menu, which is alphabetically pleasing and less jarring than the Canny filter.
  • ImageChannel invocations now reuse the original Alpha channel (when Alpha is not the channel being modified) to preserve transparent canvas operations.
  • ImageChannelOffset now lets Hue (HSV) loop over when out of [0..255] bounds

Related Issues / Discussions

Mostly satisfies #4942 but does not have contrast/sharpness abilities.

QA Instructions

A Value of 1 is no change. 0 and 2 are -255 and +255 respectively. At Value=0.5, 128 will be subtracted from each pixel in the selected channel, with results clipping to a minimum of 0.
If "Scale Values" is true, the graph will switch to using using the Multiply node, which directly uses the Value slider as the scalar input. Values above 2 can be entered manually.

adjust_image_short.mp4

Merge Plan

Ready to merge.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations frontend PRs that change frontend files labels Jan 26, 2025
@hipsterusername
Copy link
Member

Very cool. 🤘

Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@psychedelicious psychedelicious enabled auto-merge (rebase) February 4, 2025 00:54
@psychedelicious psychedelicious merged commit 8fc5d3d into invoke-ai:main Feb 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants