-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automated footer copyright year #16202
base: master
Are you sure you want to change the base?
Conversation
Hi @AdeshGhadage. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@@ -7,9 +7,6 @@ full_version: "1.25.0" | |||
# The previous Istio version identifier the docs describe, used for upgrade documentation | |||
previous_version: "1.24" | |||
|
|||
# The year to display in copyright notices | |||
copyright_year: 2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the git blame to see why this was added, confirm it was only used in that one place?
It seems like an obvious thing to use "now", which makes it feel like there's a reason - probably so the archive sites have a copyright date of when they were released, and not always "now".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright_year field was first added in PR #3071 . It was originally introduced for the copyright footer and has only been updated since then.
Description
Implemented dynamically update footer copyright year for issue #16199.
Reviewers