Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HistoricOneToOneField #1394

Merged
merged 18 commits into from
Nov 20, 2024
Merged

HistoricOneToOneField #1394

merged 18 commits into from
Nov 20, 2024

Conversation

JordanHyatt
Copy link
Contributor

@JordanHyatt JordanHyatt commented Sep 16, 2024 •
edited
Loading

Adds support for HistoricOneToOneField

Description

Implemented the solution proposed by @quadracik in issue #1031

Related Issue

This PR addresses issue #1031 and #1389

Motivation and Context

How Has This Been Tested?

Appropriate unit tests have been written and follow the ones written for HistoricForeignKey

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

This was referenced Sep 16, 2024
Closed
Closed
@erry-whiskypartners
Copy link

Hi, is this going to be merged and if so when please

@JordanHyatt
Copy link
Contributor Author

Hi, is this going to be merged and if so when please

Waiting for maintainers to review!

tim-schilling
tim-schilling requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again Jordan! There are some documentation changes I think we should make and a few more I have questions about.

simple_history/models.py Outdated Show resolved Hide resolved
simple_history/models.py Show resolved Hide resolved
simple_history/tests/models.py Outdated Show resolved Hide resolved
simple_history/tests/models.py Show resolved Hide resolved
simple_history/tests/models.py Outdated Show resolved Hide resolved
simple_history/tests/models.py Outdated Show resolved Hide resolved
simple_history/tests/models.py Outdated Show resolved Hide resolved
simple_history/tests/tests/test_models.py Outdated Show resolved Hide resolved
docs/signals.rst Outdated Show resolved Hide resolved
docs/querying_history.rst Outdated Show resolved Hide resolved
@tim-schilling
Copy link
Contributor

We also need to credit @david-homelend in the commit. See https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

JordanHyatt and others added 2 commits November 19, 2024 18:14
@JordanHyatt
- created HistoricDescriptorMixin to DRY out get_queryset method
0743cfd 
- Added suggested doc string to HistoricOneToOneField

- Updated test doc strings
@JordanHyatt @david-homelend
Updated doc string and adding co-author
f7a77d3 
Co-authored-by: David Diamant <[email protected]>
@JordanHyatt
Copy link
Contributor Author

Ok, I made the requested changes, let me know if I missed/messed something up!

@JordanHyatt
Copy link
Contributor Author

I had to update language_version: python3.11 in the .pre-commit-config.yaml because it was failing to find a python3.8 interpreter

tim-schilling
tim-schilling approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some last clean-up tweaks. When CI passes, I'll merge. Thank you for the PR!

@JordanHyatt
Copy link
Contributor Author

I made some last clean-up tweaks. When CI passes, I'll merge. Thank you for the PR!

Sounds Good! I think we also need to give quadracik credit. It was his solution from issue #1031 that I mostly borrowed from.

@tim-schilling
Copy link
Contributor

I'll give it a go, no promises that it'll work because I don't have their email address. Sorry @quadracik if it doesn't work 🤞

@tim-schilling tim-schilling merged commit 4325591 into jazzband:master Nov 20, 2024
17 checks passed
@tim-schilling
Copy link
Contributor

It worked! 🎉

@JordanHyatt JordanHyatt deleted the historic-one-to-one branch November 20, 2024 19:37
@quadracik
Copy link
Contributor

Thanks guys! I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeidel kgeidel kgeidel approved these changes

@tim-schilling tim-schilling tim-schilling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JordanHyatt @erry-whiskypartners @tim-schilling @quadracik @kgeidel