Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MSI US storefront #3199

Merged
merged 14 commits into from
Jan 30, 2025
Merged

feat: add MSI US storefront #3199

merged 14 commits into from
Jan 30, 2025

Conversation

alanbixby
Copy link
Contributor

⚠depends on updates in #3198

Description

This change adds all of the current GPUs on the https://us-store.msi.com/ storefront - consequently, 4060, 4070, 4070super, and 4070ti are newly added series types with their corresponding filter parameters as well

Testing

image

image

image

Other Changes

config.ts has been modified such so if SHOW_ONLY_SERIES= is blank, all series with defined in the notify config except test:series and captcha-deterrent are activated automatically - which should hopefully make this one less items to maintain when adding new series

currency: '$',
labels: {
inStock: {
container: '#button-cart',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for those of you camping out for the pre-order launch (since MSI isnt shipping on launch day)

inStock: {
    // Unknown what the pre-order text looks like so lets see what sticks!
    container:
      '#product_qty button:not([onclick^="compare.add"]):not([onclick^="notify.showNotify"])',
    text: [''],
  }

should capture anything that isnt explicitly the existing compare or notify me buttons - this is too aggro for the production release though IMO

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chef's kiss

Thank you for the additional store and the awesome work that lead up to it!

'xboxss',
'xboxsx',
]),
showOnlySeries: envOrArray(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much, much cleaner and clear 🥂 Thank you!

@jef jef merged commit c596c20 into jef:main Jan 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants