Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remember last connected servers #82

Merged
merged 18 commits into from
Apr 10, 2024

Conversation

vvvrrooomm
Copy link
Contributor

@vvvrrooomm vvvrrooomm commented Apr 17, 2022

Sever auto-discovery introduced a nice way to switch between local servers. In a setup with (at least) one remote server which is not auto-discoverable we have to type the server url again after every switch.

It would be nice to remember the last (LRU) connected servers and add them to the list of auto-discovered items.
Remembered servers are displayed first, auto-discovered next. Servers which are both, remembered and auto-discovered are displayed only once (as long as the id did not change). The last 3 servers are stored
A different color could be used to distinguish the 2 types of servers.

This PR is a showcase to find out if such functionality is desired, it works on my TV (webOS5.3) and now also tested on webos3.0 emulator
If acceptable testing for other webos versions can be done

@anthonylavado
Copy link
Member

I apologize for the super long delay on this. I had the wrong notification settings set. As a PR with features, I like it. Since it will change the first screen flow, I won't include it on the first release, but as an update right after. I want to keep the release as similar as possible to everything tested, and LG gets you to write a user flowchart for navigating all the screens, which I wouldn't have a chance to update right now.

I will get this in soon though.

@e-bacho
Copy link

e-bacho commented Oct 2, 2023

I just realised the PR I just opened is kind of similar to this. Would love to get an update from someone on whether we can merge this (and when).

@anthonylavado
Copy link
Member

@e-bacho I'm so sorry for the extra super delayed response. I'll merge whichever works better. I've had to recreate the LG SDK setup again for the third time on my system, and want to get something in for webOS 4.0. I know it's subjective, but because it might take me a while to get sim/emu set up, let me know which PR you'd want me to look at first. This one, or yours?

@e-bacho
Copy link

e-bacho commented Dec 3, 2023

@anthonylavado Thank you for your response. This PR is probably better suited, it'd be good to get this merged in. I am happy to close my PR.

It's an absolute pain typing in the server URL on the TV each time you change between multiple servers which should technically be remembered.

Much appreciated!

@anthonylavado anthonylavado merged commit 9a423fd into jellyfin:master Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants