Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental 'Details' widget for builds #10147
base: master
Are you sure you want to change the base?
Add experimental 'Details' widget for builds #10147
Changes from 24 commits
1c71f4c
991f787
f4f8ec9
701e7a7
959a43b
4deafbd
1a7bd33
abf4d00
73a48c0
5d13a62
0da339b
8886cd9
6fd6b1b
8cdc3a6
538ba93
c1cbb0d
cac4625
c649255
b4b01ee
64babad
7f11407
d6cf74c
c53e9d5
3647925
cd2d792
0085d2c
89d64f0
924683c
bfcbed3
b7dbb88
64929b5
d3ad66e
a7878e7
cbf4681
72e1ab0
2e85c62
aff8281
91c8e48
aac7d48
d09ffe9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so weird only because it doesn't use
@Extension
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not extensible if it doesn't handle
getOrder
clashes gracefully.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
Action
this would be the job of the factory. Why create an object just to discard it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair, I was using
isApplicable
to encapsulate show/hide logic of the detail inside of theDetail
, so that its factory didn't need to worry about that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these not
@Extension(ordinal = …)
?