Improve the appearance of user avatars in Jenkins

[janfaracik]

User avatars are a little clunky right now in Jenkins, e.g. they're square, can be misaligned and low resolution. This small PR aims to fix those issues and make them presentable in Jenkins. Jenkins doesn't support avatars for users out of the box, but with plugins like Gravatar they appear across the system.

Before (user page)

After

---

Before (Command Palette)

After

---

Before (All users page)

After

Testing done

Proposed changelog entries

• Improve the appearance of user avatars in Jenkins

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[janfaracik]

Unrelated - but keeps it consistent with the default user icon.

[daniel-beck]

Why a circle instead of a rounded rectangle? The latter leaves more content visible.

[janfaracik]

Why a circle instead of a rounded rectangle? The latter leaves more content visible.

That's a good question, and one that I can't really answer with actual evidence. It's entirely subjective, but circular avatars align with contemporary design trends, are a little softer on the eye and I think nowadays they're rather synonymous with representing user avatars (so at a glance its more obvious what they are).

[daniel-beck]

Thanks! Not sure to what degree Jenkins should align with trends that seem to change faster than we're able to adapt (I would err on the side of "not"), but

synonymous with representing user avatars (so at a glance its more obvious what they are)

seems like a good reason to do this.

[krisstern]

Makes sense

[timja]

LGTM

[krisstern]

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

[paul-uz]

How do you even set a user avatar?!

[janfaracik]

How do you even set a user avatar?!

You can use a plugin like Gravatar to set an avatar, there's also Avatar but it needs updating/adopting.

[paul-uz]

Should this update not have been administered by those plugins?

[janfaracik]

Should this update not have been administered by those plugins?

The extension point doesn't have a way of controlling the appearance of avatars, so this was the easiest way.