-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow shutdown of executors, to clean up resources. #62
Open
lapo-luchini
wants to merge
7
commits into
jhalterman:master
Choose a base branch
from
andxor:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1b02832
Allow shutdown of executors, to clean up resources.
lapo-luchini 705d1b1
Interrupt running tasks.
lapo-luchini 8b64676
Add shutdown() test case.
lapo-luchini 6cb40a4
Fix test case by using a custom thread factory.
lapo-luchini a0c2e3e
Merge branch 'master' of github.com:jhalterman/expiringmap
lapo-luchini 7f11acd
Add JavaDoc as requested upstream.
lapo-luchini a4b96bc
JavaDoc. Minimize diff.
lapo-luchini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
package net.jodah.expiringmap; | ||
|
||
import net.jodah.expiringmap.internal.NamedThreadFactory; | ||
import org.testng.annotations.Test; | ||
|
||
import java.util.concurrent.TimeUnit; | ||
|
||
import static org.testng.Assert.assertEquals; | ||
|
||
/** | ||
* Tests ExpiringMap shutdown procedure. | ||
*/ | ||
@Test | ||
public class ShutdownTest { | ||
private static final String BASE_NAME = "TestThread-"; | ||
|
||
private static int expirationThreads() { | ||
int n = 0; | ||
for (Thread t : Thread.getAllStackTraces().keySet()) | ||
if (t.getName().startsWith(BASE_NAME)) | ||
++n; | ||
return n; | ||
} | ||
|
||
/** | ||
* Ensures that the service thread are properly shutdown. | ||
*/ | ||
public void shouldCloseThreads() throws Exception { | ||
// Initial cleanup | ||
ExpiringMap.setThreadFactory(new NamedThreadFactory(BASE_NAME + "%s")); | ||
ExpiringMap.shutdown(); | ||
|
||
// Given | ||
ExpiringMap<String, String> map = ExpiringMap.builder().expiration(100, TimeUnit.MILLISECONDS).build(); | ||
|
||
// When | ||
for (int i = 0; i < 100; i++) | ||
map.put("John" + i, "Joe"); | ||
|
||
// Then | ||
assertEquals(expirationThreads(), 1); | ||
ExpiringMap.shutdown(); | ||
Thread.sleep(100); | ||
assertEquals(expirationThreads(), 0); | ||
|
||
// Final cleanup | ||
ExpiringMap.THREAD_FACTORY = null; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get some javadoc here indicating what this method does? It should mention when and why you might want to use it, and that it affects all ExpiringMap instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will add it as soon as I'm back in the office.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(sorry, I was on other projects and time has flown by)