Use TreeMap to store headers #2113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
TreeMap
branch
3 times, most recently
from
c61f7fa to
8fb0e17
Compare
Isira-Seneviratne
force-pushed
the
TreeMap
branch
from
8fb0e17 to
6f2f151
Compare
|
Hmm - this looks neater, but it changes the semantics. The LinkedHashMap implementation keeps the headers in the order they are added. But the TreeMap will sort them alphabetically. The LinkedHashMap is a deliberate choice to maintain the original order. I thought we had tests to verify the order was maintained but I guess not. That would be good to add... |
Isira-Seneviratne
force-pushed
the
TreeMap
branch
from
27ed18e to
e8b6664
Compare
# Conflicts: # src/main/java/org/jsoup/helper/HttpConnection.java
|
@Isira-Seneviratne I think we need to close this one, as mentioned, using a TreeMap will lose the insert order of the headers. I want to keep the insertion order so that it reflects the order that they were sent by the server. LMK if you have another idea for the case insensitive scan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
TreeMapclass to store the headers, as it allows keys to be checked case-insensitively.