-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 111: change all examples to eliminate deprecated class. #112
base: master
Are you sure you want to change the base?
Conversation
…ew inconsistent indentation issues while at it.
Hi @jplflyer , your fix is accorded to the Cleanup class documentation, so I'm OK with it. Thanks for your contribution |
I entirely removed the code I commented out. I'd left it in there for historical purposes, but it's gone, with the associated comments. It looks like my IDE automatically removes trailing whitespace in C++ code. I didn't know it was doing that. That is probably the explanation for many of the extra changes. I don't have time to spend another 2 hours on this right now. Deadlines at work and deadlines at night. Perhaps you're happy with this the way it is. Perhaps you will leave this dangling, and if I ever get time, I can figure out how to leave your trailing whitespaces alone, but that won't be this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the removing of comments. But I prefer to wait you remove all remaining spaces differences, because it can create some merge conflicts when merging with other contributors work.
Thanks for your understanding.
@@ -100,5 +101,7 @@ int main(int argc, char *argv[]) | |||
std::cout << e.what() << std::endl; | |||
} | |||
|
|||
curlpp::terminate(); | |||
|
|||
return EXIT_FAILURE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you want to return retVal here ?
Use of the curlpp::Cleanup class is commented as deprecated in the include file, but it's being used in all the examples. This commit changes all of them to use
In a few places, I also fixed inconsistent indentation within the file, but I didn't try to fix different indentation styles across all the examples.