Return seed callback to enable awaiting result

ensures that the seed command can complete all of its async work and exit properly and makes it so that errors can be caught and logged (lines 45–47)
jplhomer · Jan 28, 2025 · 37d05e5 · 37d05e5
1 parent eda1ad7
commit 37d05e5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/packages/superflare/cli/db/seed.ts b/packages/superflare/cli/db/seed.ts
@@ -36,7 +36,6 @@ export async function seedDb(dbName: string, seedPath: string) {
       if (!d1Database) {
         throw new Error(`Database ${dbName} not found`);
       }
-      // TODO: Find out why errors in the seeder are not bubbled to this try/catch
       if (seedModule.default) {
         await seedModule.default(d1Database);
         logger.info(`Seeding complete!`);

diff --git a/packages/superflare/src/seeder.ts b/packages/superflare/src/seeder.ts
@@ -3,6 +3,6 @@ import { setConfig } from "./config";
 export function seed(callback: () => void) {
   return (database: D1Database) => {
     setConfig({ database: { default: database } });
-    callback();
+    return callback();
   };
 }